You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The queryStats got collected and will only be logged in debug mode. However, it is usually quite expensive to enable debug if we only want to utilize some of the fields in queryStats.
The text was updated successfully, but these errors were encountered:
yeya24
changed the title
Proposal: expose bucket store queryStats as part of Series response
Proposal: expose bucket store queryStats as part of Series response hints
May 8, 2023
Is your proposal related to a problem?
Thanos Store Gateway collects query stats in https://github.com/thanos-io/thanos/blob/main/pkg/store/bucket.go#L3050 during
Series
request. However, for projects that use Thanos as a library, such as Cortex, there is no way to utilize that queryStats.The queryStats got collected and will only be logged in debug mode. However, it is usually quite expensive to enable debug if we only want to utilize some of the fields in queryStats.
Describe the solution you'd like
Add a bool field called to enable return queryStats in https://github.com/thanos-io/thanos/blob/main/pkg/store/hintspb/hints.proto#L22.
Accordingly, the query stats fields will be added into the hints response here https://github.com/thanos-io/thanos/blob/main/pkg/store/hintspb/hints.proto#L29.
The text was updated successfully, but these errors were encountered: