thanos store broken regex

[danielmotaleite]

Thanos: improbable/thanos:v0.3.1
Prometheus: 2.5.0

What happened
Query the line below and thanos store will return all return all http_status, not just 522. If i disabled thanos store, it returns nothing (as there are no 522 at this time)
cloudflare_pop_http_responses_sent{http_status=~"522",colo_id=~"LIS"}

What you expected to happen
thanos store should respect the field regex

How to reproduce it (as minimally and precisely as possible):
I tried several thing to reproduce and looks like this works with any field data (eg: hostname: host123 and hostname: host456) and that is in the thanos store. The query regex must not have real regex data that would match something directly (eg: hostname=~".ost123"), it must not match anything, so it tried substring (eg: hostname=~"ost123" )
thanos store will return data for all both hostname with that last query, but only return the host123 in the previous

Full logs to relevant components

[danielmotaleite]

i reverted to thanos 0.3.0 and the problem is gone, so it's something that changed in that version, probably in this commit #839 by @bwplotka

Of course, i can also workaround with a correct regex, but it's still a different behavior from prometheus

[waderobson]

I'm seeing this issue too.

[benclapp]

This sounds like issue #833, which has been fixed by #862 but not yet released.

[waderobson]

Yup, I'm good now thanks @benclapp I didn't notice that.