Upgrade Prometheus & Alertmanager #4094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Github CI seems broken and failures are not related, in any case I'm going to run the tests locally. |
pracucci
force-pushed
the
upgrade-prometheus-common
branch
from
b9144ea
to
875be09
Compare
yeya24
previously approved these changes
Apr 22, 2021
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
upgrade-prometheus-common
branch
from
875be09
to
71fd7f5
Compare
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We've an use case in Cortex for which we need to upgrade Prometheus and the Alertmanager. Some breaking changes were introduced in the HTTP client (from
prometheus/common) so we need to upgrade it in Thanos too.What's the sentiment if we do such upgrade in Thanos as well?
Verification
Existing tests