Add tracing to exemplar APIs #4299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Billett <ibillett@redhat.com>
Signed-off-by: Ian Billett <ibillett@redhat.com>
kakkoyun
reviewed
Jun 3, 2021
Co-authored-by: Kemal Akkoyun <kakkoyun@users.noreply.github.com> Signed-off-by: Ian Billett <ibillett@redhat.com>
bill3tt
force-pushed
the
add-tracing-to-exemplar-endpoints
branch
from
0901471
to
fb293b6
Compare
|
Think this puppy is ready to merge 💪 |
|
nice :)) |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Follows #4238 & #4178 - adds tracing instrumentation to the exemplar endpoints.
Closes #4130
Verification
Standard tests pass:
I have been trying and failing to figure out an additional unit test to verify this behaviour.
It might be possible to setup a grpc server with a
basictracer-goand register the exemplar APIs then verify spans are created when the API is called. Previous tracing PRs have not included this so might not be worth the effort 🤷