Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query-frontend: make HTTP downstream tripper configurable #4623

Merged

Conversation

GiedriusS
Copy link
Member

Make the HTTP downstream tripper configurable so that it would be
possible to set the number of maximum idle connections per host to more
than 2 so that HTTP keep-alive connections could be used on higher
loads.

Solves #4571.

Signed-off-by: Giedrius Statkevičius giedrius.statkevicius@vinted.com

Make the HTTP downstream tripper configurable so that it would be
possible to set the number of maximum idle connections per host to more
than 2 so that HTTP keep-alive connections could be used on higher
loads.

Solves thanos-io#4571.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, super cool work! Thanks, LGTM

@bwplotka bwplotka enabled auto-merge (squash) September 1, 2021 14:47
@bwplotka bwplotka merged commit 4aebd03 into thanos-io:main Sep 1, 2021
@GiedriusS GiedriusS deleted the feature/configurable_downstream_tripper branch September 1, 2021 14:50
someshkoli pushed a commit to someshkoli/thanos that referenced this pull request Nov 7, 2021
…4623)

* query-frontend: make HTTP downstream tripper configurable

Make the HTTP downstream tripper configurable so that it would be
possible to set the number of maximum idle connections per host to more
than 2 so that HTTP keep-alive connections could be used on higher
loads.

Solves thanos-io#4571.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>

* CHANGELOG: add entry

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants