Fix: Filter block rows in bucket UI according to searched block ID #5102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: soumya <somu12.ss@gmail.com>
Signed-off-by: soumya <somu12.ss@gmail.com>
GiedriusS
reviewed
Jan 28, 2022
GiedriusS
reviewed
Jan 28, 2022
| @@ -146,3 +146,21 @@ export const getBlocksByCompactionLevel = (blocks: Block[], compactionLevel: num | |||
| const blockResult = blocks.filter((block) => block.compaction.level === compactionLevel); | |||
| return blockResult; | |||
| }; | |||
|
|
|||
| export const getFilteredBlockPools = ( | |||
There was a problem hiding this comment.
Maybe we could add a unit test or two for this?
There was a problem hiding this comment.
Yeah for sure, I can add one
There was a problem hiding this comment.
Hey @GiedriusS you can review now
Signed-off-by: soumya <somu12.ss@gmail.com>
|
@yeya24 @GiedriusS can anyone run CI for this PR |
Nicholaswang
pushed a commit
to Nicholaswang/thanos
that referenced
this pull request
Mar 6, 2022
…hanos-io#5102) * added helper function to filter block rows Signed-off-by: soumya <somu12.ss@gmail.com> * updated store UI to show filtered block rows Signed-off-by: soumya <somu12.ss@gmail.com> * added unit tests for getFilteredBlockPools function Signed-off-by: soumya <somu12.ss@gmail.com> Signed-off-by: Nicholaswang <wzhever@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5044
Changes
Verification
UI preview
Attached a short video file that demonstrates my implementation.
Screencast.from.25-01-22.08.29.35.PM.IST.mp4