query frontend, store: Add TLS support to redis_client #5674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While looking to update the docs (& changelog), I noticed that Would it be better to structure the redis TLS config using the same idiom? |
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
dbut023
force-pushed
the
redis-ssl
branch
4 times, most recently
from
8bea081
to
6bb70b5
Compare
I thought about it more and decided to go with the |
dbut023
changed the title
dbut023
force-pushed
the
redis-ssl
branch
2 times, most recently
from
ccaf096
to
a5e856d
Compare
GiedriusS
reviewed
Sep 27, 2022
…loses issue thanos-io#5310 Signed-off-by: Daniel Butler <16944132+dbut023@users.noreply.github.com>
Signed-off-by: Daniel Butler <16944132+dbut023@users.noreply.github.com>
matej-g
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds support for TLS connections to redis (Fixes #5310)
Modified original PR #5312 to use NewConfigClient as per pharau
Adds tls_client_cert, tls_client_key and tls_ca_cert options for Client Certificate and custom Root CA.Adds tls_enabled and reuses tls_config struct from http to configure specifics.
Verification
Expanded unit tests to validate new configuration