gate: allow disabling max concurrent #6053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow disabling max concurrency limit by setting limit to <= 0. Previously it was impossible to disable this limit. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
fpetkovski
reviewed
Jan 18, 2023
|
I doubt it makes much sense to set the limit to 0 as it is because it effectively disables everything 😄 what would be the use-case for that? 🤷 |
|
In Golang the zero value is usually used to indicate no limit, e.g. setting a timeout of 0 would mean no timeout etc.. Also as you pointed out, making the semantics of |
fpetkovski
reviewed
Jan 18, 2023
fpetkovski
approved these changes
Jan 18, 2023
matej-g
approved these changes
Jan 19, 2023
GiedriusS
added a commit
to vinted/thanos
that referenced
this pull request
Jan 26, 2023
Allow disabling max concurrency limit by setting limit to <= 0. Previously it was impossible to disable this limit. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Co-authored-by: Matej Gera <38492574+matej-g@users.noreply.github.com> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
sshantel
pushed a commit
to sshantel/thanos
that referenced
this pull request
Jan 28, 2023
Allow disabling max concurrency limit by setting limit to <= 0. Previously it was impossible to disable this limit. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Co-authored-by: Matej Gera <38492574+matej-g@users.noreply.github.com>
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
Allow disabling max concurrency limit by setting limit to <= 0. Previously it was impossible to disable this limit. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Co-authored-by: Matej Gera <38492574+matej-g@users.noreply.github.com>
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
Allow disabling max concurrency limit by setting limit to <= 0. Previously it was impossible to disable this limit. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Co-authored-by: Matej Gera <38492574+matej-g@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow disabling max concurrency limit by setting limit to <= 0. Previously it was impossible to disable this limit.
Signed-off-by: Giedrius Statkevičius giedrius.statkevicius@vinted.com