-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
objstore: Update to latest #6104
Merged
saswatamcode
merged 1 commit into
thanos-io:main
from
farodin91:objstore-update-to-latest
Feb 9, 2023
Merged
objstore: Update to latest #6104
saswatamcode
merged 1 commit into
thanos-io:main
from
farodin91:objstore-update-to-latest
Feb 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farodin91
force-pushed
the
objstore-update-to-latest
branch
3 times, most recently
from
February 7, 2023 15:34
96856c4
to
0724a66
Compare
saswatamcode
previously approved these changes
Feb 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Can you run make docs
to fix the check?
Seems like the unit test failure is also related.
farodin91
force-pushed
the
objstore-update-to-latest
branch
2 times, most recently
from
February 8, 2023 12:06
d65a0af
to
142e2ba
Compare
saswatamcode
reviewed
Feb 9, 2023
farodin91
force-pushed
the
objstore-update-to-latest
branch
2 times, most recently
from
February 9, 2023 06:49
44dbd47
to
0ac0a93
Compare
Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
farodin91
force-pushed
the
objstore-update-to-latest
branch
from
February 9, 2023 06:50
0ac0a93
to
65017ab
Compare
fpetkovski
approved these changes
Feb 9, 2023
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updates Objstore to latest.
Includes:
Verification