feat: Use non root user as default user in container image #6107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matej-g
reviewed
Feb 9, 2023
Signed-off-by: Timo Haas <haastimo@gmx.de>
matej-g
approved these changes
Mar 17, 2023
|
Thank you @timo-42! |
This was referenced Aug 23, 2023
4 tasks
richardtief
added a commit
to sapcc/helm-charts
that referenced
this pull request
Jan 4, 2024
The upstream Thanos image has changed the default user in the container image to 1001 instead of 0 (root). thanos-io/thanos#6107 As we are dependent on user 0 in our environment, we explicitly set it to 0.
viennaa
pushed a commit
to sapcc/helm-charts
that referenced
this pull request
Jan 4, 2024
The upstream Thanos image has changed the default user in the container image to 1001 instead of 0 (root). thanos-io/thanos#6107 As we are dependent on user 0 in our environment, we explicitly set it to 0.
|
Hi, just wondering why this change was made? We have our thanos compactor running as any UID and this change is breaking for us. We can get it to work in our K8s cluster by making sure it runs as root, but we'd rather not have it do that. Any suggestions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Timo Haas haastimo@gmx.de
Changes
Changed default user in container images from 0 to 1001
Verification
Tested thanos-query in k8s cluster