Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override compilerOpts in the target #24

Closed
vogdb opened this issue Apr 17, 2013 · 6 comments
Closed

Override compilerOpts in the target #24

vogdb opened this issue Apr 17, 2013 · 6 comments

Comments

@vogdb
Copy link
Contributor

vogdb commented Apr 17, 2013

Hi! It would be nice to have a possibility to override compilerOpts in the target. In my project I build several files. They all use different extern files. That is why this feature is important to me.

I've made a draft implementation for 'closureCompiler' task here vogdb/grunt-closure-tools@f30472d84cd670eae604c18d91ee094021febd40 If this implementation is OK I can do it for other tasks.

@thanpolas
Copy link
Owner

@vogdb is this issue what you are talking about? gruntjs/grunt#738

@vogdb
Copy link
Contributor Author

vogdb commented Apr 17, 2013

Yeah. I didn't know about it. Should I close this issue or wait until grunt will be updated?

@thanpolas
Copy link
Owner

I'm curious how your solution works, can you make a gist with how your conf looks like after that patch?

@vogdb
Copy link
Contributor Author

vogdb commented Apr 17, 2013

@thanpolas
Copy link
Owner

aha! that's interesting. @vogdb we can have this as an interim solution until Grunt supports it.

Would you care to submit a PR?

Please also update the README and CHANGELOG, make sure docs reflect the temporary nature of this configuration option

@vogdb
Copy link
Contributor Author

vogdb commented Apr 19, 2013

OK.

@vogdb vogdb closed this as completed Apr 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants