-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Before publishing to npm, build and package JS/CSS assets #8
Comments
@iamkevingreen I think this was taken care of a while back, not sure by who: https://github.com/the-couch/slater/blob/master/packages/theme/package.json#L8 |
I mean when you first zip and manually import the theme into shopify. |
@iamkevingreen I believe you are using the @estrattonbailey recommend this one be closed |
Thanks @wardpenney! Kev and I talked about this offline and what he really means is that before we publish to npm, we should build JS/CSS so that when a user jumps in for the first time they won't have to do a full upload. I was confused at first as well, haha. |
@wardpenney yeah, the intention here is not to deploy into the debut theme (which comes with shopify out of the box), we don't want the additional bloat of that theme since deploying doesn't remove files from a theme it only overrides them. Instead we should prepare a zip file that is an easy upload for first time use, perhaps some npm package for building a compressed file prior to our npm pushes. |
Only impacts first upload of theme, would be nice to have the compiled version by default and not need to run
npm run start
to see the latest update of styles/jsThe text was updated successfully, but these errors were encountered: