Let user choose about attachment handling #1173

cm-schl · 2023-06-13T10:14:15Z

cm-schl
Jun 13, 2023

Hi @the-djmaze,
I searched inside the issues but did not find if this is even possible. As there were some issues about the .eml attachments I made some tests and would like to discuss something.
Is there really some eml viewer inside of SnappyMail that will try to show the content of the .eml file? Or is SnappyMail only passing the correct mime type message/rfc822 to the browser and therefore the browser is handling the visualization of the .eml?

The problem that I see actually is, that some mails are not shown correctly when the user clicks on the .eml attachment and there seams no easy possibility to open the .eml with a local program (on computer, not mobile). The only workaround that I found is to download the attachment as zip and open it locally afterwards...

From the mobile first perspective to have a .eml viewer is perfectly fine - but maybe there should be an option to open the mail with a local program. What do you say about this idea?

the-djmaze · 2023-06-13T12:52:25Z

the-djmaze
Jun 13, 2023
Maintainer

The "view in separate window" code is here:
https://github.com/the-djmaze/snappymail/blob/master/dev/Html/PreviewMessage.html

snappymail/dev/Model/Message.js

Lines 339 to 364 in ed31ed2

    
           viewPopupMessage(print) { 
        
           	const 
        
           		timeStampInUTC = this.dateTimestamp() || 0, 
        
           		ccLine = this.cc.toString(), 
        
           		bccLine = this.bcc.toString(), 
        
           		m = 0 < timeStampInUTC ? new Date(timeStampInUTC * 1000) : null, 
        
           		win = open('', 'sm-msg-'+this.requestHash 
        
           			/*,newWindow ? 'innerWidth=' + elementById('V-MailMessageView').clientWidth : ''*/ 
        
           		), 
        
           		sdoc = win.document, 
        
           		subject = encodeHtml(this.subject()), 
        
           		mode = this.isHtml() ? 'div' : 'pre', 
        
           		to = `<div>${encodeHtml(i18n('GLOBAL/TO'))}: ${encodeHtml(this.to)}</div>` 
        
           			+ (ccLine ? `<div>${encodeHtml(i18n('GLOBAL/CC'))}: ${encodeHtml(ccLine)}</div>` : '') 
        
           			+ (bccLine ? `<div>${encodeHtml(i18n('GLOBAL/BCC'))}: ${encodeHtml(bccLine)}</div>` : ''), 
        
           		style = getComputedStyle(doc.querySelector('.messageView')), 
        
           		prop = property => style.getPropertyValue(property); 
        
           	sdoc.write(PreviewHTML 
        
           		.replace('<title>', '<title>'+subject) 
        
           		// eslint-disable-next-line max-len 
        
           		.replace('<body>', `<body style="background-color:${prop('background-color')};color:${prop('color')}"><header><h1>${subject}</h1><time>${encodeHtml(m ? m.format('LLL',0,LanguageStore.hourCycle()) : '')}</time><div>${encodeHtml(this.from)}</div>${to}</header><${mode}>${this.bodyAsHTML()}</${mode}>`) 
        
           	); 
        
           	sdoc.close(); 
        
           	print && setTimeout(() => win.print(), 100); 
        
           }

Difference between RainLoop and SnappyMail is that SnappyMail can parse EML into a MessageModel (RainLoop can not) using https://github.com/the-djmaze/snappymail/tree/master/dev/Mime
Then SnappyMail uses the same code as RainLoop to view it using MessageModel.viewPopupMessage()

To see attachments, the code needs a complete rewrite with enhancements to handle attachments.

1 reply

cm-schl Jun 13, 2023
Author

Ok, thanks for the information 👍.
I'm fine if SnappyMail can open the .eml directly in the browser, this is nice. But that the user can't download an .eml (besides the download as zip workaround) is a bit irritating for users. If the user clicks on the name of the file, the eml viewer opens. If the users clicks on the eye icon, the raw content opens...

Would be adding a download link inside the eml viewer solve the problem? So the code could remain the same in sense of opening the eml viewer, but the user has always the choice to download the original eml. This would also mitigate the situation in #1166 a bit - nevertheless this isn't a real solution to the question.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Let user choose about attachment handling #1173

{{title}}

Replies: 1 comment 1 reply

{{title}}

{{title}}

Select a reply

Let user choose about attachment handling #1173

cm-schl Jun 13, 2023

Replies: 1 comment · 1 reply

the-djmaze Jun 13, 2023 Maintainer

cm-schl Jun 13, 2023 Author

cm-schl
Jun 13, 2023

Replies: 1 comment 1 reply

the-djmaze
Jun 13, 2023
Maintainer

cm-schl Jun 13, 2023
Author