Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download attachments as ZIP doesn't work for PGP encrypted mail #1499

Closed
mindsolve opened this issue Mar 15, 2024 · 1 comment
Closed

Download attachments as ZIP doesn't work for PGP encrypted mail #1499

mindsolve opened this issue Mar 15, 2024 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@mindsolve
Copy link

Describe the bug
When trying to use the "Download as ZIP" function for attachments in a PGP-decrypted message, a small red "X" appears and nothing else happens.

To Reproduce
Steps to reproduce the behavior:

  1. Receive a PGP-encrypted e-mail, with an attachment
  2. Open and decrypt the message
  3. Click on the small cogwheel below the attachment(s)
  4. Select at least one attachment, then click the "Download as ZIP" button
  5. Observe a red cross icon instead of the "ZIP archive"-icon before and nothing else happening

Expected behavior
I would expect the attachment(s) to be downloaded in a ZIP archive, or, if impossible when using a PGP message, the function to not be visible.

Screenshots
grafik

Please complete the following information:

  • Browser: Firefox 123.0.1
  • IMAP daemon: dovecot
  • PHP version: 8.1.2-1ubuntu2.14
  • SnappyMail Version: 2.35.3
  • Mode: standalone

Debug/logging information
snappymail-debug-pgp-zip-attachment-download.log

Additional context
Add any other context about the problem here.

@the-djmaze the-djmaze added bug Something isn't working enhancement New feature or request labels Mar 15, 2024
@the-djmaze
Copy link
Owner

the-djmaze commented Mar 16, 2024

It's not only PGP decrypted messages.
It failed for any message that is parsed in JavaScript.

The fix is not pretty as it requires to upload all attachments to the server.
Then the server makes the zip.
Then the server returns link to the zip.
Then the browser downloads the zip from server.

Maybe better to have a "create zip" JavaScript library.
But the Nextcloud integration does require the uploads to the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants