Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light/Dark Favicon Logo #643

Closed
distresscode opened this issue Nov 8, 2022 · 4 comments
Closed

Light/Dark Favicon Logo #643

distresscode opened this issue Nov 8, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@distresscode
Copy link

The favicon is black and is visible if you're using light mode in the browser. However, it's hard to see with any dark theme/mode on. I suggest adding two logos and have it change depending on the system/browser theme. I'm not sure how github does it but changes from either a white or black favicon.

It looks much darker depending on the angle you're sitting at.
snappy

snappy2

@the-djmaze
Copy link
Owner

@distresscode
Copy link
Author

@the-djmaze what does it mean in layman's terms? don't let my username fool you.. I'm no coder :)

@the-djmaze
Copy link
Owner

the-djmaze commented Nov 8, 2022

It means that github has a special svg.
So i added one to the code.

@distresscode
Copy link
Author

Good to know. Thanks for the speedy update!

@the-djmaze the-djmaze added the enhancement New feature or request label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants