Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cosmetic] Scroll bar with the mobile version in "Advanced search" screen #712

Closed
Massedil opened this issue Nov 26, 2022 · 8 comments
Closed

Comments

@Massedil
Copy link

  1. Scroll bar appears with width = 360px while there is space available in the first col :

advanced search

  1. By the way, a lot of space is available when width = 788px :

1

@Massedil
Copy link
Author

  1. There is also an horizontal scroll bar if an email is too large (normal), but the scroll bar makes the header section scroll too (not normal). Expected : only the email body scroll from left to right ; not the headers.

@the-djmaze
Copy link
Owner

This is a very conflicting case.
In each language the size of text is different.
You have Répondu and Portuguese have Respondidas.

Répondu
Respondidas

Since most of the code is still based on Bootstrap.css (yes i hate it, but RainLoop choose for it and changing it is a lot of time and effort).
It is mostly inline-block based with fixed width (flex didn't exist or good supported by browsers).

Feel free to "fix" this if you want.

@Massedil
Copy link
Author

Massedil commented Dec 5, 2022

Feel free to "fix" this if you want.

For point 1 and 2, can you review this ?

<style>

@media screen and (max-width: 999px) {
	
	#advancedsearchform .row,
	#advancedsearchform .span4, 
	#advancedsearchform select, 
	#advancedsearchform .control-group > * {
		width: 100% ;
		margin-left:0 ;
	}
	
}

</style>

It looks like this for me :

Capture d’écran 2022-12-05 à 18 27 10

@Massedil
Copy link
Author

Massedil commented Dec 5, 2022

And for the point n°3, can you review this :

.bodyText {
	overflow: scroll;
}

@the-djmaze
Copy link
Owner

You were on the right track.
I've modified it a bit so that bootstrap .row and .span4 are not used.

@Massedil
Copy link
Author

Massedil commented Dec 6, 2022

I just updated to 2.22.7 and it well solves the horizontal scrollbar, thanks !

  • I think you forgot to solve my point n°3 (overflow: scroll on .bodyText to avoid the actual scroll on #messageItem)

  • About the two other points, you didn't wanted to use all the available space at the right ? I have this :

Capture d’écran 2022-12-06 à 15 44 17

Capture d’écran 2022-12-06 à 15 44 45

@the-djmaze
Copy link
Owner

  • About the two other points, you didn't wanted to use all the available space at the right ?

Well i had wacky jumping results with Firefox on <select> they didn't become width: 100% ; but the same width as the largest option inside.
So that needs a bit more thought.

@Massedil
Copy link
Author

Massedil commented Dec 6, 2022

And about the actual scroll on #messageItem ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants