Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make B.E.N.J.I. recognize positions of "stream" and "play" #83

Open
rohanricky opened this issue Dec 18, 2017 · 7 comments
Open

Make B.E.N.J.I. recognize positions of "stream" and "play" #83

rohanricky opened this issue Dec 18, 2017 · 7 comments

Comments

@rohanricky
Copy link
Contributor

Since youtube play feature is above download it is causing few bugs errors.
For example, if I type download Coldplay Paradise, it contains play so it is playing the video. Similarily, Chainsmokers Bloodstream contains stream.

@the-ethan-hunt
Copy link
Owner

Nice spotting the bug, @rohanricky !

@the-ethan-hunt the-ethan-hunt changed the title Clash between play and download! Make B.E.N.J.I. recognize positions of "stream" and "play" Dec 18, 2017
@the-ethan-hunt
Copy link
Owner

This issue is open for discussion: @aribalam , @kb-studios @Yatish04 . You all are open to discuss this issue

@kaushal-py
Copy link
Contributor

kaushal-py commented Dec 18, 2017

As this can be a very broad issue, can we start off using NLP gradually, maybe using nltk? We can do basic tokenizing.

@the-ethan-hunt
Copy link
Owner

Good thinking @kb-studios ! But tokenizing requires a knowledge of NLP. But though won't fix for sometime, this is a good issue for discussion

@Yatish04
Copy link
Contributor

Yeah we have to use nlp at the end of the day.😀 So as of now it's limited

@rohanricky
Copy link
Contributor Author

rohanricky commented Dec 18, 2017

For now we can reverse it's order to get it working or since we are using download and play at starting only we can use .startwith() for this also. This is just a quick fix eventually we can work on nlp.

@the-ethan-hunt
Copy link
Owner

You are right @rohanricky in this sense. We can use that temporarily. You can work on this issue. but we are not closing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants