Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the events list to filter out past events #33

Closed
rodneybarnes opened this issue Sep 22, 2019 · 1 comment
Closed

Refactor the events list to filter out past events #33

rodneybarnes opened this issue Sep 22, 2019 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@rodneybarnes
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
The GraphQL query for the events roll currently uses a hard-coded date to filter the requested events; as a result, this needs to be manually changed to remove events from the published page.

Describe the solution you'd like

Instead, I think we can use a .find method after the query is run to filter out the dates (see: https://spectrum.chat/gatsby-js/general/using-variables-in-a-staticquery~abee4d1d-6bc4-4202-afb2-38326d91bd05).

Describe alternatives you've considered

I had thought we could use a variable in the query, but apparently variables do not currently work with StaticQuery components.
[See the above link]

Other options include manually deleting old events from the repo, but this destroys information we may want in the future and is also not as optimal a solution as solving this programmatically.

Additional context

@rodneybarnes rodneybarnes added help wanted Extra attention is needed enhancement New feature or request labels Sep 22, 2019
@rodneybarnes
Copy link
Collaborator Author

Fixed with PR #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant