New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add hannah910 Rev.1 & Rev.2 #33

Merged

wilba merged 2 commits into the-via:master from mechlovin:dev_mechlovin

Feb 2, 2020

Contributor

mechlovin commented Jan 28, 2020 •

edited

Loading

Description

add hannah910 config to VIA

QMK PR: qmk/qmk_firmware#8024

Types of Changes

Adding a keyboard to VIA
Changing a keyboard already in VIA
Bug fix
Documentation

Checklist

I have tested this keyboard definition using VIA's "Design" tab.
I have tested this keyboard definition with firmware on a device.
The QMK firmware can be built using QMK master repo.


          add hannah910 Rev.1 & Rev.2

e69041f

mechlovin closed this

mechlovin reopened this

Contributor Author

mechlovin commented Feb 1, 2020

@Wilba6582 PR was merged, could you please check if everything's ok now?
Thank you!

mechlovin requested a review from wilba

February 1, 2020 05:20

Contributor

wilba commented Feb 1, 2020

Can you please add colors to indicate alphas/mods/accent keys?

https://caniusevia.com/docs/layouts#kle-json-rules


          add color

b16561e

wilba merged commit 2b20cec into the-via:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet