Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onClickOutside and onEscapeKey doesn't update callbacks #17

Closed
makarov906 opened this issue Sep 12, 2019 · 3 comments · Fixed by #19
Closed

onClickOutside and onEscapeKey doesn't update callbacks #17

makarov906 opened this issue Sep 12, 2019 · 3 comments · Fixed by #19
Assignees
@theKashey

Comments

@makarov906
Copy link

Hello @theKashey,

I have realised that onClickOutside and onEscapeKey doesn't update callbacks.
I did some research, and I think it because useEffect in Effect.tsx doesn't get deps for update those funcs (here)

Or maybe there is another way to do this?
@theKashey theKashey self-assigned this Sep 12, 2019
@theKashey
Copy link
Owner

The easiest way - just fix the root cause.

theKashey added a commit that referenced this issue Sep 14, 2019
@theKashey
fix: update hooks when users changes callbacks, fixes #17
127a303
@theKashey theKashey mentioned this issue Sep 14, 2019
Merged
@theKashey
Copy link
Owner

I've drafter PR with the possible fix for this issue, but it would take some time to actually test it.

@theKashey
Copy link
Owner

Released as 3.1.1 beta, as long as I haven't found time to test it in isolation, so gonna test in some external projects first, before removing a beta flag.
Join the club.

@benoitgrelard benoitgrelard mentioned this issue Oct 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theKashey theKashey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update hooks when users changes callbacks theKashey/react-focus-on
2 participants
@theKashey @makarov906