Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signatures must match #192

Open
theKashey opened this issue Jun 24, 2020 · 5 comments
Open

Signatures must match #192

theKashey opened this issue Jun 24, 2020 · 5 comments

Comments

@theKashey
Copy link
Owner

theKashey commented Jun 24, 2020

Another loadable found for an existing mark. That's possible, signatures must match:

Minification could produce different code in different files, resulting different code for importers in requires and the actual location.

in case of problem just propose your own case as a "red test".

@intelcoder
Copy link

Thank you for your effort.
Can you help me to understand how to fix this issue or why this issue happen?
issue 191 shows to let user "fix" the problem with minification

This means I have wrong configuration for minification?

@theKashey
Copy link
Owner Author

This means I have wrong configuration for minification?

No @intelcoder, that means that me has a wrong code for de-minification.

@theKashey
Copy link
Owner Author

#191 is about allowing user to create their own matchers, for example in 99% of cases it could just use import mark, not the whole import function signature, which is very fragile.

@intelcoder
Copy link

Thanks for the all comments

@theKashey
Copy link
Owner Author

One could set checkSignatures: false, via the setConfiguration or imported.json to disable signature comparison - only mark(filename) would be used in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants