V2 bringup #4
V2 bringup #4
Conversation
|
I think we can rework this commit after transitioning to |
|
I just realised the doctests are completely broken they just pass all the time Edit: It seems that errors that occur in Edit: I'm just doing this now /// # #[tokio::main]
/// # async fn main() -> Result<(), ferinth::Error> {
/// ...actual test...
/// # Ok(()) }Not checking |
Good idea. On that note I'd prefer for the "modloader" enum be placed somewhere more global. I did consider also using it for the |
|
I think the intended way to specify/read mod loaders is to get them from the mod loaders tag |
- Remove `tokio-test` dependency - All doctests now use a `#[tokio::main]` runtime instead of `tokio_test::block_on()` - Add a `URLParseError` which is wrapper of `url::ParseError` - Removed `request_rel`. You're expected to use `join()` on the `API_URL_BASE` - Created a lazy static `url::Url` `API_URL_BASE` - All api call functions have transitioned from `format!(...)` to `API_URL_BASE.join(...)` - Updated tag api calls to the v2 API - Tags now have their own structs - All enums now have `#[serde(rename_all = "lowercase")]` - All structs now have `#[serde(deny_unknown_fields)]` - Add the example project to the workspace - Improved documentation
|
I've done pretty much everything needed to release v2. Any suggestions @4JX? |
Would still fancy filtering for It seems more convenient than doing the same thing with code on the program later on given the API provides support for it. |
|
Ah I see I thought we'd make a seperate pr for that and mod searching. Would releasing that in v2.1 be okay, or you seriously need that feature now? |
Actually yes sounds good 👍. Go for it. |
|
I'll migrate ferium to this to test for any edge cases first. Is a changelog necessary? I mean it's a major release so obviously everything has changed |
Other than "you should probably substitute mod with project in your function calls" you can probably do a mobile dev changelog and throw everything else under "various improvements" |
Haha I was thinking of just doing "Initial release" and maybe linking this PR as a 'changelog' |
|
Ferium works fine! Just had to change |
A PR extension (?) of #3