fix: type for plain action creator. Fixes #143 #144

SantoJambit · 2020-03-04T12:37:18Z

I had to create a new type ExactActionCreator since the ActionCreator type did not specify TCallable. Modifying ActionCreator didn't seem viable since it would introduce a breaking change.

Not sure about the name of this new type. maybe you have a better idea.

Release v3.2.0 and v3.1.0

Release v3.2.1

codecov · 2020-03-04T12:41:19Z

Codecov Report

Merging #144 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #144   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines          56     56           
  Branches        9      9           
=====================================
  Hits           56     56

Impacted Files	Coverage Δ
src/create-action-creator.ts	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d209aba...b997cb5. Read the comment docs.

SantoJambit · 2020-03-04T12:59:59Z

I'm assuming the deploy fails are not related to my PR.

the-dr-lazy · 2020-03-04T15:56:41Z

@SantoJambit Thank you for submitting this PR. Can you add a test case to DTS tests for this PR? It can check for type checker failure on application of arguments to a nullary function (action creator created by createActionCreator).

SantoJambit · 2020-03-04T16:08:35Z

Correct me if I'm wrong, but I thought the snapshot already takes care of that:

-exports[`createActionCreator createActionCreator('[Todo] truncate') (type) should match snapshot 1`] = `"(<_T>(...args: any[]) => { type: \\"[Todo] truncate\\"; }) & { type: \\"[Todo] truncate\\"; toString(): \\"[Todo] truncate\\"; }"`;
+exports[`createActionCreator createActionCreator('[Todo] truncate') (type) should match snapshot 1`] = `"ExactActionCreator<\\"[Todo] truncate\\", () => { type: \\"[Todo] truncate\\"; }>"`;

This shows, that the returned function may not receive any args.

SantoJambit · 2020-03-04T16:26:20Z

I think I get what you want.. you want typescript errors in the dts.spec file. As long as this builds, I can try something.

SantoJambit · 2020-03-04T16:55:40Z

@thebrodmann hope this is what you wanted.

src/__tests__/__snapshots__/create-action-creator.dts.spec.ts.snap

SantoJambit · 2020-03-11T08:45:52Z

@thebrodmann anything missing?

the-dr-lazy · 2020-03-16T15:50:41Z

Absolutely not. Sorry for the latency. Let's go for the release of this honor.

## [3.2.2](v3.2.1...v3.2.2) (2020-03-16) ### Bug Fixes * type for plain action creator. ([#144](#144)) ([709fe60](709fe60)), closes [#143](#143)

the-dr-lazy · 2020-03-16T15:59:19Z

🎉 This PR is included in version 3.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

* fix: type for plain action creator. Fixes #143 * fix: more type tests for createActionCreator * fix: adjustments after code review Co-authored-by: Mohammad Hasani <20781126+thebrodmann@users.noreply.github.com>

SantoJambit · 2020-03-17T08:59:07Z

Thanks!

* fix: type for plain action creator. Fixes #143 * fix: more type tests for createActionCreator * fix: adjustments after code review Co-authored-by: Mohammad Hasani <20781126+thebrodmann@users.noreply.github.com>

## [3.2.2](v3.2.1...v3.2.2) (2020-03-16) ### Bug Fixes * type for plain action creator. ([#144](#144)) ([709fe60](709fe60)), closes [#143](#143)

This reverts commit f228b81.

* fix: type for plain action creator. Fixes #143 * fix: more type tests for createActionCreator * fix: adjustments after code review Co-authored-by: Mohammad Hasani <20781126+thebrodmann@users.noreply.github.com>

## [3.2.2](v3.2.1...v3.2.2) (2020-03-16) ### Bug Fixes * type for plain action creator. ([#144](#144)) ([709fe60](709fe60)), closes [#143](#143)

the-dr-lazy · 2020-10-01T20:38:08Z

🎉 This PR is included in version 3.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

# [3.3.0](v3.2.1...v3.3.0) (2020-10-01) ### Bug Fixes * handle.others instead of handle.default ([ffe271b](ffe271b)) * more explicit typing to avoid TS4025 ([25b78c3](25b78c3)) * type for plain action creator. ([#144](#144)) ([f228b81](f228b81)), closes [#143](#143) ### Features * default handler in createReducer ([0b3dfcf](0b3dfcf)), closes [#152](#152)

## [3.2.2](v3.2.1...v3.2.2) (2020-10-01) ### Bug Fixes * type for plain action creator. ([#144](#144)) ([5a43381](5a43381)), closes [#143](#143) ### Reverts * Revert "fix: type for plain action creator. (#144)" ([52cecce](52cecce)), closes [#144](#144) * Revert "chore(release): 3.2.2 [skip ci]" ([2c24a35](2c24a35)) * Revert "chore(deps): bump acorn from 5.7.3 to 5.7.4 in /examples/tasks" ([8ac4f81](8ac4f81)) * Revert "test: remove redundant tests" ([f3585b0](f3585b0)) * Revert "chore(dependencies): update lockfiles" ([0807302](0807302)) * Revert "feat: default handler in createReducer" ([8dc28bb](8dc28bb)) * Revert "fix: more explicit typing to avoid TS4025" ([c1b1d23](c1b1d23)) * Revert "refactor: create-handler-map.ts" ([12f7519](12f7519)) * Revert "fix: handle.others instead of handle.default" ([0c27324](0c27324)) * Revert "ci: thanks to Circle CI sanctions!" ([b95295f](b95295f)) * Revert "test: fix unknown `default` handler" ([bc569d7](bc569d7))

# [3.3.0](v3.2.1...v3.3.0) (2020-10-01) ### Bug Fixes * handle.others instead of handle.default ([ffe271b](ffe271b)) * more explicit typing to avoid TS4025 ([25b78c3](25b78c3)) * type for plain action creator. ([#144](#144)) ([f228b81](f228b81)), closes [#143](#143) ### Features * default handler in createReducer ([0b3dfcf](0b3dfcf)), closes [#152](#152)

* fix: type for plain action creator. Fixes the-dr-lazy#143 * fix: more type tests for createActionCreator * fix: adjustments after code review Co-authored-by: Mohammad Hasani <20781126+thebrodmann@users.noreply.github.com>

## [3.2.2](the-dr-lazy/deox@v3.2.1...v3.2.2) (2020-03-16) ### Bug Fixes * type for plain action creator. ([the-dr-lazy#144](the-dr-lazy#144)) ([709fe60](the-dr-lazy@709fe60)), closes [the-dr-lazy#143](the-dr-lazy#143)

# [3.3.0](the-dr-lazy/deox@v3.2.1...v3.3.0) (2020-10-01) ### Bug Fixes * handle.others instead of handle.default ([ffe271b](the-dr-lazy@ffe271b)) * more explicit typing to avoid TS4025 ([25b78c3](the-dr-lazy@25b78c3)) * type for plain action creator. ([the-dr-lazy#144](the-dr-lazy#144)) ([f228b81](the-dr-lazy@f228b81)), closes [the-dr-lazy#143](the-dr-lazy#143) ### Features * default handler in createReducer ([0b3dfcf](the-dr-lazy@0b3dfcf)), closes [the-dr-lazy#152](the-dr-lazy#152)

# [3.3.0](v3.2.1...v3.3.0) (2020-10-09) ### Bug Fixes * handle.others instead of handle.default ([ffe271b](ffe271b)) * more explicit typing to avoid TS4025 ([25b78c3](25b78c3)) * type for plain action creator. ([#144](#144)) ([f228b81](f228b81)), closes [#143](#143) ### Features * default handler in createReducer ([0b3dfcf](0b3dfcf)), closes [#152](#152)

# [3.3.0](v3.2.1...v3.3.0) (2020-10-17) ### Bug Fixes * handle.others instead of handle.default ([ffe271b](ffe271b)) * more explicit typing to avoid TS4025 ([25b78c3](25b78c3)) * type for plain action creator. ([#144](#144)) ([f228b81](f228b81)), closes [#143](#143) * use symbol for the `others` handler ([3aa61fe](3aa61fe)) ### Features * default handler in createReducer ([0b3dfcf](0b3dfcf)), closes [#152](#152)

the-dr-lazy and others added 3 commits December 9, 2019 21:15

Merge pull request the-dr-lazy#137 from thebrodmann/next

8fe1758

Release v3.2.0 and v3.1.0

Merge pull request the-dr-lazy#142 from thebrodmann/next

d209aba

Release v3.2.1

fix: type for plain action creator. Fixes the-dr-lazy#143

ba1f5ad

fix: more type tests for createActionCreator

b54f347

the-dr-lazy requested changes Mar 4, 2020

View reviewed changes

src/__tests__/__snapshots__/create-action-creator.dts.spec.ts.snap Show resolved Hide resolved

fix: adjustments after code review

b997cb5

the-dr-lazy changed the base branch from master to next March 16, 2020 15:51

the-dr-lazy merged commit 709fe60 into the-dr-lazy:next Mar 16, 2020

the-dr-lazy pushed a commit that referenced this pull request Mar 16, 2020

chore(release): 3.2.2 [skip ci]

8888197

## [3.2.2](v3.2.1...v3.2.2) (2020-03-16) ### Bug Fixes * type for plain action creator. ([#144](#144)) ([709fe60](709fe60)), closes [#143](#143)

the-dr-lazy added the released on @next label Mar 16, 2020

the-dr-lazy assigned SantoJambit Mar 16, 2020

the-dr-lazy added this to the v3.2.2 milestone Mar 16, 2020

SantoJambit deleted the plain-action-creator branch March 17, 2020 08:58

the-dr-lazy pushed a commit that referenced this pull request Oct 1, 2020

chore(release): 3.2.2 [skip ci]

22a27bc

## [3.2.2](v3.2.1...v3.2.2) (2020-03-16) ### Bug Fixes * type for plain action creator. ([#144](#144)) ([709fe60](709fe60)), closes [#143](#143)

the-dr-lazy mentioned this pull request Oct 1, 2020

The automated release is failing 🚨 #155

Closed

the-dr-lazy added a commit that referenced this pull request Oct 1, 2020

Revert "fix: type for plain action creator. (#144)"

2f53396

This reverts commit f228b81.

the-dr-lazy added a commit that referenced this pull request Oct 1, 2020

Revert "fix: type for plain action creator. (#144)"

52cecce

This reverts commit f228b81.

the-dr-lazy pushed a commit that referenced this pull request Oct 1, 2020

chore(release): 3.2.2 [skip ci]

9205364

## [3.2.2](v3.2.1...v3.2.2) (2020-03-16) ### Bug Fixes * type for plain action creator. ([#144](#144)) ([709fe60](709fe60)), closes [#143](#143)

the-dr-lazy added the released on @3.2.x label Oct 1, 2020

the-dr-lazy mentioned this pull request Oct 1, 2020

Release v3.3.0 #158

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: type for plain action creator. Fixes #143 #144

fix: type for plain action creator. Fixes #143 #144

SantoJambit commented Mar 4, 2020

codecov bot commented Mar 4, 2020 •

edited

Loading

SantoJambit commented Mar 4, 2020

the-dr-lazy commented Mar 4, 2020 •

edited

Loading

SantoJambit commented Mar 4, 2020

SantoJambit commented Mar 4, 2020

SantoJambit commented Mar 4, 2020

SantoJambit commented Mar 11, 2020

the-dr-lazy commented Mar 16, 2020

the-dr-lazy commented Mar 16, 2020

SantoJambit commented Mar 17, 2020

the-dr-lazy commented Oct 1, 2020

fix: type for plain action creator. Fixes #143 #144

fix: type for plain action creator. Fixes #143 #144

Conversation

SantoJambit commented Mar 4, 2020

codecov bot commented Mar 4, 2020 • edited Loading

Codecov Report

SantoJambit commented Mar 4, 2020

the-dr-lazy commented Mar 4, 2020 • edited Loading

SantoJambit commented Mar 4, 2020

SantoJambit commented Mar 4, 2020

SantoJambit commented Mar 4, 2020

SantoJambit commented Mar 11, 2020

the-dr-lazy commented Mar 16, 2020

the-dr-lazy commented Mar 16, 2020

SantoJambit commented Mar 17, 2020

the-dr-lazy commented Oct 1, 2020

codecov bot commented Mar 4, 2020 •

edited

Loading

the-dr-lazy commented Mar 4, 2020 •

edited

Loading