You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've started using this library on a fresh project, looks really promising. However I've noticed one issue. When passing falsy values to action creator it seems to not get attached to the created action.
Passing any falsy value would make payload not appear on created action. Maybe action function could at least check if that value is undefined and then ignore payload, otherwise just add payload?
The text was updated successfully, but these errors were encountered:
@martynaskadisa I'm so grateful to you for your contribution.
Passing any falsy value would make payload not appear on created action. Maybe action function could at least check if that value is undefined and then ignore payload, otherwise just add payload?
I'm agree with you. Also there is a similar problem with any falsy meta.
## [1.1.1](v1.1.0...v1.1.1) (2019-02-20)
### Bug Fixes
* attach non-undefined falsy values to payload and meta of action ([1fd8ed8](1fd8ed8)), closes [#15](#15)
I've started using this library on a fresh project, looks really promising. However I've noticed one issue. When passing falsy values to action creator it seems to not get attached to the created action.
Example:
Seems to be related to here:
https://github.com/thebrodmann/deox/blob/b7be530ec77ce81f24692f7438daeebfea7b74a7/src/action.ts#L81
Passing any falsy value would make payload not appear on created action. Maybe
action
function could at least check if that value isundefined
and then ignore payload, otherwise just add payload?The text was updated successfully, but these errors were encountered: