Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Android NDK installation to a composite action #167

Open
kendalharland opened this issue Jun 27, 2024 · 1 comment
Open

Move Android NDK installation to a composite action #167

kendalharland opened this issue Jun 27, 2024 · 1 comment

Comments

@kendalharland
Copy link
Contributor

kendalharland commented Jun 27, 2024

The new steps to install the Android NDK in swift-toolchain.yml would be great candidates for a composite action that takes the NDK version and hash as inputs, and optionally sets the ANDROID_NDK and ANDROID_NDK_ROOT environment variables. Android-Determine.cmake will derive CMAKE_ANDROID_NDK from these values if set (See these lines), allowing us to remove the explicit matrix.extra_flags entries we use to pass this value to cmake.

Here's an example workflow run where I tested this behavior while building libxml2: https://github.com/thebrowsercompany/swift-build/actions/runs/9704486640/job/26784869710

CC @hyp @compnerd

@compnerd
Copy link
Collaborator

Why not use nttld/setup-ndk?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants