Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test "registers a new user with password confirmation and logs in" #117

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

ch4r-ch4r
Copy link
Contributor

If the setting registration_include_name_field => true, then this test fails with:

Component has errors: "name"
Failed asserting that false is true.
at vendor/livewire/livewire/src/Features/SupportValidation/TestsValidation.php:109
at tests/Feature/AuthenticationTest.php:94

Just adding name as in the other existing registration test in this same file.

@tnylea tnylea changed the base branch from main to fix-test-registers-a-new-user September 20, 2024 12:22
@tnylea
Copy link
Contributor

tnylea commented Sep 20, 2024

Hey @ch4r-ch4r, In order to get the tests to pass correctly, I need to test the PR against a branch on the main repo. So, I've changed the base to merge into this branch fix-test-registers-a-new-user and I've re-opened the PR here: #128 👍

@tnylea tnylea merged commit b748833 into thedevdojo:fix-test-registers-a-new-user Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants