Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix social providers component and two factor authentication page closing tags #118

Conversation

ch4r-ch4r
Copy link
Contributor

pretty straightforward, the closing tag did not match for a couple of elements, changed x-auto for x-auth

@tnylea tnylea changed the base branch from main to fix-social-providers-tags September 20, 2024 12:25
@tnylea
Copy link
Contributor

tnylea commented Sep 20, 2024

Thanks for this PR @ch4r-ch4r, In order for the tests to run successfully, they must run against a PR on the main branch. So, I've changed this PR to be merged into a branch called fix-social-providers-tags, and I've re-created this PR here #129 👍

@tnylea tnylea merged commit b721c9c into thedevdojo:fix-social-providers-tags Sep 20, 2024
@tnylea tnylea mentioned this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants