Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow autocompletion for email and password inputs #142

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

alajusticia
Copy link
Contributor

This pull request allows web browsers and password managers to autocomplete the email and password inputs:

  • adding the autocomplete on email and password inputs
  • adding the name property where missing (in order to provide autocompletion, user-agents might require inputs to have a name and/or id attribute)

In the login page, I've made sure that the password input is present in the DOM right from the start, because otherwise in some cases the credentials autocompletion doesn't work (for example with the Google Password Manager in Chrome).
The password input is hidden by default and I change its CSS classes to show it when required.

@bobbyiliev bobbyiliev requested a review from tnylea December 1, 2024 14:04
@tnylea
Copy link
Contributor

tnylea commented Dec 4, 2024

Thanks @alajusticia!

It looks good. I'll get this merged in tomorrow 👏

@tnylea tnylea changed the base branch from main to allow-autocomplete December 4, 2024 02:04
@tnylea tnylea merged commit d2f4843 into thedevdojo:allow-autocomplete Dec 4, 2024
1 check passed
@tnylea
Copy link
Contributor

tnylea commented Dec 4, 2024

I'm going to merge this into the allow-autocomplete branch and then I'll merge that into main to make sure all the tests pass.

Here is the PR that will be merged into main ;) #144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants