Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login container alignment #80

Conversation

skdishansachin
Copy link
Contributor

Response to issue #77

The alignment on the Login page wasn't working properly. When changed the alignment in the authentication setup, it affected the registration page but not the login page; it was stuck in the bottom right corner of the screen. I've updated the code, and now it's working as expected. The alignment changes now take effect and work on both pages.

@tnylea
Copy link
Contributor

tnylea commented Jul 9, 2024

Thanks @skdishansachin

I'll be getting this one merged in tomorrow 👍 Appreciate it!

@skdishansachin
Copy link
Contributor Author

@tnylea Sounds good to me. I wonder why the workflow keeps failing.

@tnylea tnylea changed the base branch from main to container-alignment-fix July 12, 2024 14:45
@tnylea tnylea merged commit 12cf701 into thedevdojo:container-alignment-fix Jul 12, 2024
1 check failed
@tnylea tnylea mentioned this pull request Jul 12, 2024
@tnylea
Copy link
Contributor

tnylea commented Jul 12, 2024

@skdishansachin Thanks! So, the way that the tests run is by installing the dev-branchname from the devdojo/auth package, https://github.com/thedevdojo/auth/blob/main/.github/workflows/tests.yml#L43

We need to change that to the Forked repo that the user is trying to merge in. in the meantime, I'm going to merge this into a thedevdojo:container-fix-alignment and then merge that into main so that way we can see if the tests pass 😉

Here's the new PR here: #95

@skdishansachin
Copy link
Contributor Author

@tnylea Ohh okay now it's clear. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants