Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nc count checking is too strict #2

Open
mayoneez opened this issue Mar 12, 2012 · 0 comments
Open

nc count checking is too strict #2

mayoneez opened this issue Mar 12, 2012 · 0 comments

Comments

@mayoneez
Copy link

Hi and thanks a bunch for this wonderful library.

I noticed that it checks that the nc (nonce count) given by client must be greater than previous value. This check is too strict and causes login window to pop up on client way too often. Instead, it should only check that the same nc number is not reused. Client cannot ensure that its requests arrive to the server in order so checking for ascending order is too strict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant