-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow scc_product module without organization parameter #1675
Comments
But the account still requires the org, right? |
Tbh I don't trust my ruby code reading. |
Heh. I'll try to look in detail tomorrow. But my thinking is as follows: even if one doesn't need an Org to find a Product, one needs it to find an Account, so for the overall module call it will still be required. We have a similar thing in the "repository" module. Repositories are scoped by Product, so technically you don't need an Org if you know the ID of the Product, but finding that requires an Org… |
Unfortunately if you give hammer the organization parameter for scc_product with the list command, it will give you a flawed output (most of the products are missing). I might have misunderstood something or the info was lost in transit, but I was told that the scc_accounts will be bound to a org from the beginning, and after that the org is unnecessary, idk, I just ran into this because we wanted to subscribe to products with Ansible and we failed because the output is not complete if the org is provided (which is mandatory for the ansible module) So... as long as the organization parameter does not reach the scc_product api it should be fine I guess :) Thank you for looking into it :) |
This sounds like a bug, but yes the linked patch removes a FWIW, the apidoc for the endpoint never mentioned
Looking at the linked PR it should be fine, yes. (I don't understand why the |
Okay, so nothing to change here? As the |
That's my understanding, but I am by no means an expert on the SCC side. Maybe @Manisha15 or @sbernhard can weight in? |
I tried to dig into this but not sure if I got it all right. In my tests, you can (with the patch applied) do the following: Providing an account name without the organization does not work for a reason we have not yet figured out: Maybe it is related to what @evgeni mentioned:
If you have any insights, let me know. In FAM, you always have to set the organization but I did not experience any trouble subscribing to products using FAM. @lumarel Not sure if I could help you with that, let me know if there is anything else I should look into. |
SUMMARY
The next version of
foreman_scc_manager
will move where the organization property is needed:https://github.com/ATIX-AG/foreman_scc_manager/pull/126/files
It's currently already optional with the hammer cli for
scc_product
(and only shows correct output if organization is not defined), which makes it correctly work there.Would have done the change myself already, but as
KatelloAnsibleModule
overall requires organization I was not sure how to correctly do the change.ISSUE TYPE
The text was updated successfully, but these errors were encountered: