Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set release compatibility to 1.17+ #661

Merged
merged 5 commits into from
Aug 15, 2018
Merged

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Aug 15, 2018

No description provided.

@ekohl
Copy link
Member Author

ekohl commented Aug 15, 2018

Split off from #660 so we get a nice changelog.

@ehelms
Copy link
Member

ehelms commented Aug 15, 2018

What is the issue that leads to dropping dynflow_in_core for my understanding?

@ekohl
Copy link
Member Author

ekohl commented Aug 15, 2018

It was a compatibility setting we had so you could use the module with 1.16 if you set it to false. Then it would revert back to the foreman-tasks service. This PR is raising the minimum version to 1.17 so we can assume it's dynflowd. In a multi-host environment you can still set the ensure to stopped to only run it on a single server.

Copy link
Contributor

@mmoll mmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests fail

@ekohl ekohl force-pushed the compat-level branch 2 times, most recently from 541e6ac to 14db69b Compare August 15, 2018 17:47
@mmoll mmoll merged commit 6a505a1 into theforeman:master Aug 15, 2018
@mmoll
Copy link
Contributor

mmoll commented Aug 15, 2018

merged, bedankt @ekohl!

@ekohl ekohl deleted the compat-level branch August 16, 2018 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants