Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't break when optionLabelPath is missing #38

Merged
merged 1 commit into from
Jul 2, 2015

Conversation

tp
Copy link
Contributor

@tp tp commented Jul 1, 2015

No description provided.

@Robdel12
Copy link
Collaborator

Robdel12 commented Jul 1, 2015

Thanks for the PR! Can you write a test proving the bug?

@tp
Copy link
Contributor Author

tp commented Jul 1, 2015

It's just the same as optionValuePath, which does not have a test either as far I can tell ;-)

Will check out your setup later and submit a test.

@tp
Copy link
Contributor Author

tp commented Jul 2, 2015

Sorry, but I am new to Ember and testing it and did not quite figure out the steps required to add a new test in your current setup.

@Robdel12 Robdel12 merged commit 5dae0ad into adopted-ember-addons:master Jul 2, 2015
@Robdel12
Copy link
Collaborator

Robdel12 commented Jul 2, 2015

@tp No problem! This surfaced a lot more bugs for the blockless form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants