Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag is not changing with phone number #162

Open
babitakapoor112 opened this issue Feb 16, 2021 · 6 comments
Open

Flag is not changing with phone number #162

babitakapoor112 opened this issue Feb 16, 2021 · 6 comments

Comments

@babitakapoor112
Copy link

Hi,
I am facing a problem while changing my phone number. when I pick a country from the modal Picker and tries to change my phon number then sometimes the phone number does not reflect with that country code. Also, my flag got vanish from the input. Please see the below screenshot
https://user-images.githubusercontent.com/45659052/108027275-edd7c400-704f-11eb-8716-5ae6ad5b0082.png
https://user-images.githubusercontent.com/45659052/108027355-0ea01980-7050-11eb-96d8-fa67afe34af1.png

@unicornRainbows
Copy link

Same issue..

@aleyrizvi
Copy link

Its happening on android only.

Working fine on IOS.

Facing same issue.

@Roshdy
Copy link

Roshdy commented Feb 20, 2021

+1

@Roshdy
Copy link

Roshdy commented Feb 20, 2021

I found the problem:

in PhoneNumber.js line: 48

isNumeric(n) {
   return !Number.isNaN(parseFloat(n)) && Number.isFinite(n);
}

should be:

isNumeric(n) {
   return !Number.isNaN(parseFloat(n)) && !Number.isFinite(n);
}

Number.isFinite needs to be negated

@kovetskiy
Copy link

rili-live#2

@italoa7x
Copy link

italoa7x commented Jan 4, 2022

Has this problem been fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants