upgrade xterm to fix terminal dragging between areas #4680

akosyakov · 2019-03-23T19:10:35Z

akosyakov · 2019-03-23T19:12:00Z

@marcdumais-work What is the process now to get CQs for runtime dependencies? This fix is quite important moving terminals around is basically broken on master.

akosyakov · 2019-03-23T19:31:56Z

@svenefftinge Does it address #4319?

svenefftinge

It does! 🎉

AlexTugarev · 2019-03-25T07:57:20Z

Moving terminals around seem to work much better, @akosyakov.

Have you noticed errors on the console?

UPDATE

These errors are related to resize and reflow. Try this:

akosyakov · 2019-03-25T09:38:49Z

@AlexTugarev It seem to be xtermjs/xterm.js#1932 in xtermjs. Do you think it should be fixed before we upgrade?

AlexTugarev

Thanks! This improves moving terminals around a lot!

AlexTugarev · 2019-03-25T09:56:57Z

Do you think it should be fixed before we upgrade?

Personally, I'd say this improves the terminal a lot and it looks like there are just errors on the JS console. Despite of still broken reflow in some cases it, I haven't seen any issues using it.

👍

akosyakov · 2019-03-25T10:35:49Z

From the user perspective it does not work so bad, logs get really polluted. @svenefftinge suggested to have a filter for this error for time being, @AlexTugarev sounds good?

lmcbout · 2019-03-25T12:09:54Z

@akosyakov
This version allows us to use the terminal after we move it.

If I move the terminal to the right tab bar panel, then I resize the terminal and I restart the front-end:
--> I cannot move the terminal elsewhere anymore
--> The data in the terminal are not adjusted properly until I press "enter"
--> I cannot delete the terminal from the right tab panel unless I select "Close " from the menu
Tested on Ubuntu 16.04

See attachment:

vince-fugnitto · 2019-03-25T12:21:29Z

@akosyakov
This version allows us to use the terminal after we move it.

If I move the terminal to the right tab bar panel, then I resize the terminal and I restart the front-end:
--> I cannot move the terminal elsewhere anymore
--> The data in the terminal are not adjusted properly until I press "enter"
--> I cannot delete the terminal from the right tab panel unless I select "Close " from the menu
Tested on Ubuntu 16.04

See attachment:

I don't see the same behaviour as you @lmcbout, everything works correctly for me, maybe you can show me in person later?

marcdumais-work · 2019-03-25T12:26:33Z

This fix is quite important moving terminals around is basically broken on master.
+1

@marcdumais-work What is the process now to get CQs for runtime dependencies?

This here is a good example case, that should be very easy to deal-with, just being an updated (so previously analysed/permitted) dependency.

No official change yet to the process has been announced: we have one "NPM production dependencies CQ" for this whole repo and in theory should update it for new stuff. If we have only 1 PR waiting for the CQ, this works. But with multiple, we either need to wait until the CQ is resolved and then deal with the next one, and so on... Or somehow merge all those waiting PRs together and so obtain a single NPM "state" to submit in the CQ.

As we have seen, it can take a while for those CQs to be approved, so having a single one scales poorly. Having a "CQ branch" seems like a lot of work for not much gain.

I think we should rather have as many such CQs as needed, one per PR introducing a new or updated production dependency, each being independent from the others. Then when we submit e.g. the CQ for this PR here, the emphasis (for the Foundation) should be to check the differences vs latest approved CQ (i.e. master or close). IP issues that are applicable at large and not PR-specific (e.g. Electron) should be handled separately and not block the other CQs.

WDYT?

akosyakov · 2019-03-25T12:44:02Z

@svenefftinge @marcdumais-work Can we discuss tomorrow on dev meeting?Do we need a CQ now or we can open later and merger a PR now? I don't want to open any CQs before we agree on something to avoid confusion.

akosyakov · 2019-03-25T12:49:50Z

I cannot delete the terminal from the right tab panel unless I select "Close " from the menu
Tested on Ubuntu 16.04

@lmcbout I believe it is expected: you are confusing the toolbar with the caption is a sidebar. It is not relevant to this PR.

akosyakov · 2019-03-25T12:52:20Z

I cannot move the terminal elsewhere anymore

@lmcbout It was like that always one can drag only using the caption in sidebar, not a toolbar. If you want to allow dragging with the toolbar please file an issue. It is not related to changes in this PR.

akosyakov · 2019-03-25T12:54:50Z

The data in the terminal are not adjusted properly until I press "enter"

@lmcbout I cannot reproduce it. Could you specify what you type?

lmcbout · 2019-03-25T13:09:42Z

@akosyakov

Delete the terminal from the side panel: need to use the icon and the menu: ok Just I didn't see the "X" on the title bar as I was expecting
Moving: Again I did not expect that I had to use the icon in the side panel to allow moving: OK as it is
For the text: I just type an invalid command "xxxxxx" -> enter -> move the terminal on the right side panel -> resize the right side panel -> restart the client
===> the data in the terminal looks weird until I press "ENTER" to get the prompt back, then it looks ok after

akosyakov · 2019-03-25T13:16:28Z

This reflow feature does not feel stable, maybe we wait till it is sorted out in xterm and leave with terminals only in the bottom panel. Or help to fix it in xterm.

lmcbout · 2019-03-25T14:09:40Z

@akosyakov May be the re-flow is missing, but I think we should consider to uplift xterm to the latest version, at least if someone moves it elsewhere, the terminal won't be frozen .

marcdumais-work · 2019-03-25T14:13:22Z

@svenefftinge @marcdumais-work Can we discuss tomorrow on dev meeting?Do we need a CQ now or we can open later and merger a PR now? I don't want to open any CQs before we agree on something to avoid confusion.

@akosyakov Let me ping Sharon about this.

akosyakov · 2019-04-10T05:21:16Z

@Tyriar pointed out that bogus output on resize it is not xterm issue, but result produced by used shell: xtermjs/xterm.js#2002 (comment)

Since #4680 (comment) is going to be fixed in 3.13.0. I suggest we wait for it and then rebase and merge this PR. I hope that 3.13.0 is already around the corner :)

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

akosyakov · 2019-05-15T06:19:14Z

3.13.0 was released, good to merge?

akosyakov · 2019-05-15T06:19:45Z

packages/terminal/package.json

@@ -8,7 +8,7 @@
    "@theia/filesystem": "^0.6.0",
    "@theia/process": "^0.6.0",
    "@theia/workspace": "^0.6.0",
-    "xterm": "3.9.2"
+    "xterm": "3.13.0"


@marcdumais-work Is it fine?

Hi @akosyakov , let me run the "ECD Theia Intellectual Property Clearance, Approach" on this PR branch and get back to you. ETA ~30 mins.

Done - looks good - you can merge from a license PoV.

There was one new extra "NOASSERTION" dependency (nugget 2.0.1), but it looks to be BSD-license after investigation:

akosyakov requested review from svenefftinge, marcdumais-work, AlexTugarev and lmcbout March 23, 2019 19:10

svenefftinge approved these changes Mar 24, 2019

View reviewed changes

akosyakov mentioned this pull request Mar 25, 2019

TypeError: Cannot read property '_data' of undefined xtermjs/xterm.js#1932

Closed

AlexTugarev approved these changes Mar 25, 2019

View reviewed changes

akosyakov changed the title ~~upgrade xterm to fix terminal dragging between areas~~ WIP upgrade xterm to fix terminal dragging between areas Mar 25, 2019

This was referenced Mar 27, 2019

Terminal Chinese Language Not Support #4730

Closed

full screen mode for main and bottom areas #4744

Merged

fix #3838: upgrade xterm to fix terminal dragging between areas

9e53000

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>

akosyakov force-pushed the GH-3838 branch from 4c5b0bd to 9e53000 Compare May 15, 2019 06:18

akosyakov changed the title ~~WIP upgrade xterm to fix terminal dragging between areas~~ upgrade xterm to fix terminal dragging between areas May 15, 2019

akosyakov commented May 15, 2019

View reviewed changes

akosyakov merged commit 80c8a0d into master May 15, 2019

akosyakov deleted the GH-3838 branch May 15, 2019 11:06

vince-fugnitto mentioned this pull request Jul 11, 2019

Update to Xterm.js 3.11 #4319

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgrade xterm to fix terminal dragging between areas #4680

upgrade xterm to fix terminal dragging between areas #4680

akosyakov commented Mar 23, 2019

akosyakov commented Mar 23, 2019

akosyakov commented Mar 23, 2019

svenefftinge left a comment

AlexTugarev commented Mar 25, 2019 •

edited

Loading

akosyakov commented Mar 25, 2019

AlexTugarev left a comment

AlexTugarev commented Mar 25, 2019

akosyakov commented Mar 25, 2019

lmcbout commented Mar 25, 2019

vince-fugnitto commented Mar 25, 2019

marcdumais-work commented Mar 25, 2019

akosyakov commented Mar 25, 2019 •

edited

Loading

akosyakov commented Mar 25, 2019 •

edited

Loading

akosyakov commented Mar 25, 2019 •

edited

Loading

akosyakov commented Mar 25, 2019

lmcbout commented Mar 25, 2019

akosyakov commented Mar 25, 2019

lmcbout commented Mar 25, 2019

marcdumais-work commented Mar 25, 2019

akosyakov commented Apr 10, 2019

akosyakov commented May 15, 2019

akosyakov May 15, 2019

marcdumais-work May 15, 2019

marcdumais-work May 15, 2019

upgrade xterm to fix terminal dragging between areas #4680

upgrade xterm to fix terminal dragging between areas #4680

Conversation

akosyakov commented Mar 23, 2019

akosyakov commented Mar 23, 2019

akosyakov commented Mar 23, 2019

svenefftinge left a comment

Choose a reason for hiding this comment

AlexTugarev commented Mar 25, 2019 • edited Loading

akosyakov commented Mar 25, 2019

AlexTugarev left a comment

Choose a reason for hiding this comment

AlexTugarev commented Mar 25, 2019

akosyakov commented Mar 25, 2019

lmcbout commented Mar 25, 2019

vince-fugnitto commented Mar 25, 2019

marcdumais-work commented Mar 25, 2019

akosyakov commented Mar 25, 2019 • edited Loading

akosyakov commented Mar 25, 2019 • edited Loading

akosyakov commented Mar 25, 2019 • edited Loading

akosyakov commented Mar 25, 2019

lmcbout commented Mar 25, 2019

akosyakov commented Mar 25, 2019

lmcbout commented Mar 25, 2019

marcdumais-work commented Mar 25, 2019

akosyakov commented Apr 10, 2019

akosyakov commented May 15, 2019

akosyakov May 15, 2019

Choose a reason for hiding this comment

marcdumais-work May 15, 2019

Choose a reason for hiding this comment

marcdumais-work May 15, 2019

Choose a reason for hiding this comment

AlexTugarev commented Mar 25, 2019 •

edited

Loading

akosyakov commented Mar 25, 2019 •

edited

Loading

akosyakov commented Mar 25, 2019 •

edited

Loading

akosyakov commented Mar 25, 2019 •

edited

Loading