fix #5506: Make processId and cwd in TerminalWidget return promise when throw error

[BroKun]

Add the ready interface to ensure that the correct processId can be obtained.

Signed-off-by: Brokun brokun0128@gmail.com

[BroKun]

Currently, it works for me.
I think we can look at whether to avoid multiple calls to resolve and whether to update 'ready' when attach.

[akosyakov]

please don't expose it for now, keep protected

[akosyakov]

@BroKun How do you test it? Code-wise it looks good.

[BroKun]

@BroKun How do you test it? Code-wise it looks good.

I modified the solution to this problem because I noticed that onDidOpen can fix the exceptions caused by the call sequence. However, since processId and cwd cannot be captured by reject when an exception is thrown, it causes a problem.

As for testing, I feel that the current solution does not require special testing. The problem scenario can be observed by adding a wait time before the start method.

[akosyakov]

oh, really good catch with async code!

[akosyakov]

As for testing, I feel that the current solution does not require special testing. The problem scenario can be observed by adding a wait time before the start method.

It is better to be safe and double check.