Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[markers] support 'information' diagnostic severity #5763

Merged
merged 1 commit into from
Jul 24, 2019

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Jul 19, 2019

What it does

Fixes #5762: support information diagnostic severity (markers)

  • add support for information diagnostic severity.
  • populate the problems-view with info markers.
  • add a statusbar icon for problems to reflect info markers if present

How to test

  1. clone the repository (https://github.com/vince-fugnitto/vscode-extension-samples)
  2. cd diagnostic-related-information-sample and perform npm i && npm run compile.
  3. start Theia using diagnostic-related-information-sample as a workspace
  4. perform F1 and Hosted Plugin: Start Instance and select diagnostic-related-information-sample
  5. in the new hosted instance, open the file sample-demo.rs
  6. there should be new info markers present from the file

In general, the guidelines from the following wiki was used.

Review checklist

  • as an author, I have thoroughly tested my changes and carefully reviewed following the review guidelines

Reminder for reviewers

Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com

Fixes #5762

- add support for `information` diagnostic severity.
- populate the `problems-view` with `info` markers.
- add a statusbar icon for `problems` to reflect `info` markers if present

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added enhancement issues that are enhancements to current functionality - nice to haves markers issues related to problem markers labels Jul 19, 2019
@vince-fugnitto vince-fugnitto self-assigned this Jul 19, 2019
@vince-fugnitto
Copy link
Member Author

The PR is marked as a draft until I can successfully find an easy way for reviewers
to be able to test the new functionality and generate information markers.

Copy link
Contributor

@lmcbout lmcbout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vince-fugnitto looks good
Question: Why not completing the Diagnostics list with the "Hint", they could be handle the same way as the information on the status bar. So if there is some "Hint" value, we add it to the status bar as well?
The "Hint are already added to list of markers in the problems view.

@vince-fugnitto
Copy link
Member Author

Question: Why not completing the Diagnostics list with the "Hint", they could be handle the same way as the information on the status bar. So if there is some "Hint" value, we add it to the status bar as well?

The "Hint are already added to list of markers in the problems view.

I was thinking that adding hints would be too noisy too display on the statusbar.
(vscode doesn't display hints as well afaik, it looks like they are for editor purposes only)

@vince-fugnitto vince-fugnitto merged commit 22ef59c into master Jul 24, 2019
@vince-fugnitto vince-fugnitto deleted the vf/GH-5762 branch July 24, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves markers issues related to problem markers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[markers] support 'information' diagnostics
2 participants