Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Eclipse Foundation] Update to follow branding guidelines #5779

Merged
merged 1 commit into from
Jul 23, 2019

Conversation

marcdumais-work
Copy link
Contributor

Update repo so that we follow the Eclipse Foundation
branding guidelines. In short:

"the project name needs to be "Eclipse Theia" in the first
and all prominent occurrences, add an indication that "Theia"
is a trademark of the Eclipse Foundation in the README, and
include a link to https://www.eclipse.org/theia."

Signed-off-by: Marc Dumais marc.dumais@ericsson.com

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine, it handles all prominent instances of the Theia name and satisfies the trademark indication in the readme.

README.md Outdated
@@ -56,7 +57,7 @@ Here you can find guides and examples for common scenarios:

## Contributing

Read below to learn how to take part in improving Theia:
Read below to learn how to take part in improving Eclipse Theia:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of simplicity, I'd prefer to leave this as is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

README.md Outdated
@@ -67,7 +68,7 @@ Read below to learn how to take part in improving Theia:

## Feedback

Read below how to engage with Theia community:
Read below how to engage with Eclipse Theia community:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of simplicity, I'd prefer to leave this as is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@marcdumais-work marcdumais-work force-pushed the eclipse_foundation_branding branch 2 times, most recently from 27386c6 to e305e26 Compare July 23, 2019 14:44
README.md Outdated Show resolved Hide resolved
Update repo so that we follow the Eclipse Foundation
branding guidelines. In short:

"the project name needs to be "Eclipse Theia" in the first
and all prominent occurrences, add an indication that "Theia"
is a trademark of the Eclipse Foundation in the README, and
include a link to https://www.eclipse.org/theia."

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
@marcdumais-work
Copy link
Contributor Author

@svenefftinge I have done your suggestions, thanks.

@marcdumais-work marcdumais-work merged commit 2117353 into master Jul 23, 2019
@marcdumais-work marcdumais-work deleted the eclipse_foundation_branding branch July 23, 2019 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants