-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Eclipse Foundation] Update to follow branding guidelines #5779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine, it handles all prominent instances of the Theia name and satisfies the trademark indication in the readme.
README.md
Outdated
@@ -56,7 +57,7 @@ Here you can find guides and examples for common scenarios: | |||
|
|||
## Contributing | |||
|
|||
Read below to learn how to take part in improving Theia: | |||
Read below to learn how to take part in improving Eclipse Theia: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake of simplicity, I'd prefer to leave this as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
README.md
Outdated
@@ -67,7 +68,7 @@ Read below to learn how to take part in improving Theia: | |||
|
|||
## Feedback | |||
|
|||
Read below how to engage with Theia community: | |||
Read below how to engage with Eclipse Theia community: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake of simplicity, I'd prefer to leave this as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
27386c6
to
e305e26
Compare
Update repo so that we follow the Eclipse Foundation branding guidelines. In short: "the project name needs to be "Eclipse Theia" in the first and all prominent occurrences, add an indication that "Theia" is a trademark of the Eclipse Foundation in the README, and include a link to https://www.eclipse.org/theia." Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
e305e26
to
40c0a75
Compare
@svenefftinge I have done your suggestions, thanks. |
Update repo so that we follow the Eclipse Foundation
branding guidelines. In short:
"the project name needs to be "Eclipse Theia" in the first
and all prominent occurrences, add an indication that "Theia"
is a trademark of the Eclipse Foundation in the README, and
include a link to https://www.eclipse.org/theia."
Signed-off-by: Marc Dumais marc.dumais@ericsson.com