preserve debug view layout #5817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
requested review from
lmcbout,
AlexTugarev,
kittaakos,
azatsarynnyy,
tolusha,
spoenemann and
vince-fugnitto
akosyakov
added
debug
|
Testing right now. |
azatsarynnyy
approved these changes
Jul 30, 2019
|
I tested as described above and it works nicely in general! The only thing I was surprised about was the hight of the view at the bottom after expansion after reload ;-) |
|
I think there is an issue with travis: |
AlexTugarev
reviewed
Jul 30, 2019
| Widget.attach(this.wrapped, this.body); | ||
| MessageLoop.sendMessage(this.wrapped, Widget.Msg.BeforeAttach); | ||
| // tslint:disable-next-line:no-null-keyword | ||
| this.body.insertBefore(this.wrapped.node, null); |
There was a problem hiding this comment.
what does this do? ;-)
There was a problem hiding this comment.
do you mean null is not necessary? otherwise it appends a widget to the part body
Do you think it is temporarily or we should do something about it? |
otherwise collapsed view containers are not restored Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov
force-pushed
the
ak/preserve_debug_view
branch
from
700da87
to
f37cb19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
fix #5815: preserve the debug view layout state between reloads
commits extracted from #5665
How to test
Review checklist
Reminder for reviewers