Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dot for tsx file extension in core lib executers Node.ts #1174

Closed
lxghtless opened this issue Sep 23, 2020 · 1 comment
Closed

Missing dot for tsx file extension in core lib executers Node.ts #1174

lxghtless opened this issue Sep 23, 2020 · 1 comment
Labels
needs-verification Needs to be verified

Comments

@lxghtless
Copy link
Contributor

lxghtless commented Sep 23, 2020

Expected behavior

.tsx files should show up in code coverage.

Current behavior

.tsx files do not show up in code coverage.

Possible solution

There should be a dot in front of tsx here.

Steps to reproduce (for bugs)

  1. Run Intern against a TS base React project with .tsx files. Here's an example intern.json and command I'm using.
{
    "suites": ["test/**/*.ts", "test/**/*.tsx"],
    "coverage": ["src/**/*.ts", "src/**/*.tsx"],
    "reporters": ["runner", "jsoncoverage", "lcov", "htmlcoverage"],
    "plugins": [
        "node_modules/jsdom-global/register.js",
        "node_modules/ts-node/register/index.js"
    ],
    "environments": "node",
    "instrumenterOptions": {
        "esModules": true
    }
}

command: TS_NODE_PROJECT=test/tsconfig.json intern

  1. See that .tsx files do not show up in coverage results.

Environment

Intern version: 4.8.7
Node version: 12.18.4
NPM version: 6.14.6
Browser version: Not Applicable

Additional information

I went into node_modules and added the missing dot & that resulted in full coverage.


See PR #1175 for the fix.

@github-actions github-actions bot added the needs-verification Needs to be verified label Sep 23, 2020
@jason0x43
Copy link
Member

Resolved by a3b9643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-verification Needs to be verified
Projects
None yet
Development

No branches or pull requests

2 participants