-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plotting functions #325
base: main
Are you sure you want to change the base?
Plotting functions #325
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
==========================================
+ Coverage 53.29% 57.13% +3.84%
==========================================
Files 22 40 +18
Lines 1852 2158 +306
==========================================
+ Hits 987 1233 +246
- Misses 865 925 +60
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Oooh, you are building a python version of Marta's plotting functionality? Or is this a different visualization? Do you have an example? |
Very nice! Would be good to check if the overall score calculation is the same as for marta's code :) |
The overall score is just a simple mean of all metrics and equally weighted. I haven't yet addressed more sophisticated weighting, but I think that would be good to address as a separate problem. |
Okay... I tested different weighting approaches and converged on min-max scaling in the paper... I wouldn't test too many for now, but should be consistent with what we have for the R function. Can keep mean as well as that's useful for when you have only few methods tested. |
Provide python function for plotting metrics