Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor LISI metrics #395

Merged
merged 10 commits into from
Apr 17, 2024
Merged

Refactor LISI metrics #395

merged 10 commits into from
Apr 17, 2024

Conversation

mumichae
Copy link
Collaborator

@mumichae mumichae commented Jan 9, 2024

  • remove computational bottlenecks
  • start from harmonypy implementation for LISI TODO in new PR

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: Patch coverage is 80.55556% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 57.97%. Comparing base (59ae6ee) to head (824c146).

❗ Current head 824c146 differs from pull request most recent head fa77b53. Consider uploading reports for the commit fa77b53 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
+ Coverage   52.81%   57.97%   +5.15%     
==========================================
  Files          22       22              
  Lines        1882     1675     -207     
==========================================
- Hits          994      971      -23     
+ Misses        888      704     -184     
Flag Coverage Δ
unittests 57.97% <80.55%> (+5.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scib/metrics/lisi.py 80.47% <80.55%> (+38.18%) ⬆️

@mumichae mumichae marked this pull request as ready for review January 9, 2024 23:11
Copy link
Collaborator

@VladimirShitov VladimirShitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe, there is a bug with n_batches atm, could you please check it? Otherwise, looks good :)

scib/metrics/lisi.py Outdated Show resolved Hide resolved
@mumichae mumichae merged commit 443f89b into main Apr 17, 2024
9 of 10 checks passed
@mumichae mumichae deleted the refactor_lisi branch April 17, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants