Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spray-json, akka-http, slick shouldn't depend on instances #212

Closed
luksow opened this issue Jun 17, 2022 · 2 comments
Closed

spray-json, akka-http, slick shouldn't depend on instances #212

luksow opened this issue Jun 17, 2022 · 2 comments
Labels
easy

Comments

@luksow
Copy link
Contributor

luksow commented Jun 17, 2022

spray-json, akka-http, slick modules depend on instances which is, in general, unnecessary, even though most users would probably add instances as a dep.

I think the correct solution would be to push InstanceConverter trait to macro-utils to sit there together with CaseClass1Rep or even better, create a thin module core or base and have InstanceConverter and CaseClass1Rep there.
@luksow luksow added the easy label Jun 17, 2022
@luksow luksow mentioned this issue Jun 20, 2022
Merged
@luksow
Copy link
Contributor Author

luksow commented Jun 20, 2022

In case #214 is merged, play-json & circe should be fixed as well.

@luksow luksow mentioned this issue Dec 8, 2022
Merged
@pk044 pk044 mentioned this issue Dec 8, 2022
Open
@pk044
Copy link
Collaborator

pk044 commented Apr 21, 2023

Done in #269

@pk044 pk044 closed this as completed Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luksow @pk044