Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment option #15

Closed
kevva opened this issue Mar 27, 2015 · 4 comments
Closed

Comment option #15

kevva opened this issue Mar 27, 2015 · 4 comments

Comments

@kevva
Copy link

kevva commented Mar 27, 2015

Might be useful for some people. Something like JSZip has https://stuk.github.io/jszip/documentation/api_jszip/file_data.html.

@thejoshwolfe
Copy link
Owner

would it be useful to you? can you give me an example usecase for the comment field being helpful?

@kevva
Copy link
Author

kevva commented Mar 27, 2015

To me personally, no, but we recently switched to your library in https://github.com/sindresorhus/gulp-zip and it was requested there once. Not a super big deal, but a nice to have thing.

@thejoshwolfe
Copy link
Owner

It looks like nobody knows why this feature would be helpful. I'll certainly add it if there's a compelling usecase, but I won't add the feature just to compete with another library's list of features. Adding a useless feature (assuming the feature is useless) clutters up the code, api docs, and tests, and has a slight chance of causing complications with various unzip implementations, which are quite difficult to detect and debug.

In summary, I'm happy to add the feature if it will be valuable, bot not otherwise.

@kevva
Copy link
Author

kevva commented Mar 27, 2015

👍 Can't argue with you. I'll ping you again if we get any compelling feature requests that this really need to be added.

This issue aside, thanks for a super fast zip lib :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants