-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment option #15
Comments
would it be useful to you? can you give me an example usecase for the comment field being helpful? |
To me personally, no, but we recently switched to your library in https://github.com/sindresorhus/gulp-zip and it was requested there once. Not a super big deal, but a nice to have thing. |
It looks like nobody knows why this feature would be helpful. I'll certainly add it if there's a compelling usecase, but I won't add the feature just to compete with another library's list of features. Adding a useless feature (assuming the feature is useless) clutters up the code, api docs, and tests, and has a slight chance of causing complications with various unzip implementations, which are quite difficult to detect and debug. In summary, I'm happy to add the feature if it will be valuable, bot not otherwise. |
👍 Can't argue with you. I'll ping you again if we get any compelling feature requests that this really need to be added. This issue aside, thanks for a super fast zip lib :). |
Might be useful for some people. Something like JSZip has https://stuk.github.io/jszip/documentation/api_jszip/file_data.html.
The text was updated successfully, but these errors were encountered: