fix(article-detail): adjust page up/down scroll height for floating toolbar #4491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
robertu7
suggested changes
May 29, 2024
src/views/ArticleDetail/index.tsx
Outdated
| const remInPixels = parseFloat( | ||
| getComputedStyle(document.documentElement).fontSize | ||
| ) | ||
| const scrollDirection = event.code.toLowerCase() === 'pagedown' ? 1 : -1 |
There was a problem hiding this comment.
good call! just updated along with the keyValue enum
src/views/ArticleDetail/index.tsx
Outdated
| // offsetting it with the height of floating toolbar | ||
| useNativeEventListener('keydown', (event: KeyboardEvent) => { | ||
| if ( | ||
| event.code.toLowerCase() === 'pagedown' || |
There was a problem hiding this comment.
there is a key code mapping at src/common/enums/keyValue.ts
byhow
force-pushed
the
fix/align-page-down-event
branch
from
526ba43 to
286b0eb
Compare
byhow
force-pushed
the
fix/align-page-down-event
branch
from
286b0eb to
f4acef8
Compare
robertu7
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the presence of a floating toolbar, the normal scroll height for page up/down (fn + up/down key on OSX) hides some pixels. Now it will offset the height by the height of the toolbar
close: #4370