Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.7.0-beta.5 accidently include sharp as dependency. #1139

Closed
2 tasks done
BanDroid opened this issue Nov 20, 2023 · 4 comments
Closed
2 tasks done

v0.7.0-beta.5 accidently include sharp as dependency. #1139

BanDroid opened this issue Nov 20, 2023 · 4 comments
Labels
🐛 bug Something isn't working confirmed This bug was confirmed
Milestone

Comments

@BanDroid
Copy link

  • I have searched the Issues to see if this bug has already been reported
  • I have tested the latest version

Steps to reproduce

  1. install 0.7.0-beta.5

Current behavior

sharp is not working in termux without using proot or root privileges.

Expected behavior

install flowbite-react just fine.

Context

this is the context.

@rluders rluders added 🐛 bug Something isn't working confirmed This bug was confirmed labels Nov 20, 2023
@rluders
Copy link
Collaborator

rluders commented Nov 20, 2023

The suggestion here is to remove it as a dependency and add it during the vercel deployment since it is only used to optimize the documentation.

@SutuSebastian
Copy link
Collaborator

SutuSebastian commented Nov 20, 2023

The suggestion here is to remove it as a dependency and add it during the vercel deployment since it is only used to optimize the documentation.

I agree that we need to fix this, but could be a bit tedious to do and maintain, I think we should consider splitting the website and the library into separate packages, it is better for the long run and allows isolated package versioning

@BanDroid
Copy link
Author

BanDroid commented Nov 29, 2023

found a temporary solution, only work using pnpm, i dont know if other package manager support this settings in package.json.

"pnpm": {
 "neverBuiltDependencies": ["sharp"]
}

this will ignore running postinstall and build for sharp, because sharp is not needed in the dependency itself.

i will not close this issue yet because the temporary solution is not a full fix for this.

@tulup-conner tulup-conner added this to the 1.0.0 milestone Jan 1, 2024
@SutuSebastian
Copy link
Collaborator

Fixed in #1264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working confirmed This bug was confirmed
Projects
None yet
Development

No branches or pull requests

4 participants