Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Change yarn lint command to actually lint files #183

Merged
merged 10 commits into from
Jun 4, 2022

Conversation

tulup-conner
Copy link
Collaborator

Without a default argument, `eslint` does not run
on any files. This changes `eslint` to run on all
files except those found in `.eslintrc.js` or
`.gitignore`.
@tulup-conner tulup-conner force-pushed the fix/eslint-missing-files branch from 25af8dd to bd2e5bf Compare June 4, 2022 00:28
@tulup-conner tulup-conner marked this pull request as ready for review June 4, 2022 00:33
Removes redundant rules from `tsconfig.json`.
Deletes all of the exceptional rules defined in
`eslintrc.js` so the ruleset is standard. The only
significant change is replacing some `any`s.
This enforces the use of `import type` where possible
over `import`, possibly completely eliminating unneeded
imports from generated JavaScript (nice!)
@tulup-conner tulup-conner force-pushed the fix/eslint-missing-files branch from bd2e5bf to a986624 Compare June 4, 2022 04:28
Copy link
Collaborator

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huuuuuge

@rluders rluders merged commit 3471318 into themesberg:main Jun 4, 2022
@tulup-conner tulup-conner deleted the fix/eslint-missing-files branch June 4, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants