fix(component): Remove type="button" when not a <button>
#217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ListGroup.Item`s currently have `type="button"` always, even though they can be an anchor (`<a>`) element instead. That's changed now. Also adds `props` since they weren't being passed in for some reason.
tulup-conner
force-pushed
the
fix/list-group-item-props
branch
from
36e3db8 to
361c821
Compare
Codecov Report
@@ Coverage Diff @@
## main #217 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 127 127
Lines 7720 7722 +2
Branches 905 905
=======================================
+ Hits 7642 7644 +2
Misses 78 78
Continue to review full report at Codecov.
|
|
@tulup-conner what is missing here? :) |
|
As far as I can tell this is good to go, I'm not sure why I didn't ready it. |
|
As far as I can tell this is good to go, I'm not sure why I didn't ready it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ListGroup.Items currently havetype="button"always,even though they can be an anchor (
<a>) elementinstead. That's changed now.
Also adds
propssince they weren't being passedin for some reason.
Breaking changes
None.
Bug fixes