Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(carousel): carousel size depends on parent size #241

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

rluders
Copy link
Collaborator

@rluders rluders commented Jun 20, 2022

Description

This should fix the issue with the Carousel component. Now, it respects the size of his parent object, which allows to the user to have more flexibility over the component size and responsiveness.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Breaking changes

The Carousel must be wrapped with some div that must determine its size.

How Has This Been Tested?

  • Unit test (without any changes)
  • Storybook
  • Example page at the documentation

Test Configuration:

  • Brave Browser

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@rluders rluders requested a review from tulup-conner June 20, 2022 09:01
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #241 (1557bee) into main (43f890b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #241   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files         129      129           
  Lines        7815     7815           
  Branches      912      912           
=======================================
  Hits         7737     7737           
  Misses         78       78           
Impacted Files Coverage Δ
src/lib/theme/default.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43f890b...1557bee. Read the comment docs.

Copy link
Collaborator

@tulup-conner tulup-conner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rluders rluders merged commit 279eab4 into themesberg:main Jun 21, 2022
@rluders rluders deleted the fix-carousel branch June 21, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants