Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component): use 1st letter of text in collapsed Sidebar.Item with no icon #338

Merged
merged 4 commits into from
Aug 21, 2022

Conversation

tulup-conner
Copy link
Collaborator

@tulup-conner tulup-conner commented Aug 20, 2022

Classes placed here are applied when you create `Sidebar.Item` with an `icon` and collapse the
`Sidebar`.
… usage

We only use `mergeDeep` in one scenario currently: combine the default `<Flowbite theme>` with
custom overrides provided in `<Flowbite theme={{ theme }}>`. The default theme contains all keys. We
only need to test one scenario: given one object with all the keys, and a second object with any of
those keys, use the second (overriding) object's values.
@tulup-conner tulup-conner changed the title Fix/sidebar no icon collapse fix(component): use 1st letter of text in collapsed Sidebar.Item with no icon Aug 20, 2022
@codecov
Copy link

codecov bot commented Aug 20, 2022

Codecov Report

Merging #338 (993bc1a) into main (a9a9a87) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #338   +/-   ##
=======================================
  Coverage   98.26%   98.27%           
=======================================
  Files          89       89           
  Lines        4096     4105    +9     
  Branches      371      374    +3     
=======================================
+ Hits         4025     4034    +9     
  Misses         71       71           
Impacted Files Coverage Δ
src/lib/components/Flowbite/index.tsx 84.31% <100.00%> (ø)
src/lib/components/Sidebar/SidebarItem.tsx 100.00% <100.00%> (ø)
src/lib/helpers/mergeDeep.ts 97.14% <100.00%> (-0.08%) ⬇️
src/lib/theme/default.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tulup-conner tulup-conner marked this pull request as ready for review August 20, 2022 23:03
@tulup-conner tulup-conner requested a review from rluders August 20, 2022 23:03
@rluders rluders merged commit 103d173 into themesberg:main Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants